Spec updates #5
Merged
Spec updates #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
commented
Sep 1, 2024
Comment on lines
+20
to
+21
| * ReleaseDate | ||
| * ReleaseNotesUrl (filtered by logic for URLs on the same domain and path) |
There was a problem hiding this comment.
Had to include these two because majority of all automated PRs use either wingetcreate or Komac or some other manifest creator tool, and almost all of them pre-fill ReleaseDate & ReleaseNotesUrl in case the release is a GitHub release. If we don't include these, the percentage of "stamped" PRs that'll get auto-approved will drop significantly
denelon
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get merged into #4
For actual changes, see the 2nd commit i.e., 1be85ae. For some reason git diff shows whole file as changed (maybe because of some newline / tabs / spaces that my editor changed itself)